I actually like Carol's more recent costume (the one in your icon), enough to have cosplayed it, even, but my all-time favorite costume of hers is the the vaguely combat-gear inspired Warbird costume she's wearing in Avengers: Red Zone. I realize that body armor is totally pointless on Carol given her near-invulnerability, but it *looked* really cool.

My least favorite is probably the early costume that was basically a copy of Mar-Vell's, because it made Carol look like a female copy of him when she's very much not.